search

NCAR / noahmp

Noah-MP Community Repository
Other
72 stars 81 forks source link

Table parameters overwritten by 2D parameters in single-point simulation #76

Open CharlesZheZhang opened 1 year ago

CharlesZheZhang commented 1 year ago

For crop model and wetland model, single-point simulation reads parameter values from the table and regional simulation from 2D parameters from setup file. However, when these 2D parameters requested by regional simulation would overwrite table parameters in single-point simulation, occurred in transferring in variables in BiochemVarInMod.F90 and WaterVarInMod.F90.

For example in crop planting date: https://github.com/NCAR/noahmp/blob/fd0f6de88380d964772dabd5eba185bfc11ee37c/drivers/hrldas/BiochemVarInTransferMod.F90#L124-L137

When 2D crop input is missing, hard-coded values (126 and 290) are used in IO_code/module_NoahMP_hrldas_driver.F:

https://github.com/NCAR/hrldas/blob/dca5c8554cec5c8b7edc1c76d8585c6e37b40744/hrldas/IO_code/module_NoahMP_hrldas_driver.F#L277-L284

Suggest change:

  1. in IO_code/module_hrldas_io_netcdf.F, when reading 2D crop input, if variables are missing, pass default value from table.
  2. merge two variable names, NoahmpIO%PLANTING(I,J) from 2D file and NoahmpIO%PLTDAY(CropType) from table.