search

NCAR / obs2ioda

Converter developed by @jamiebresch to transform conventional and remote sensing observations in different formats to the IODA format needed in JEDI
4 stars 4 forks source link

Fix bug for thinning option in the goes_abi converter and update README files #5

Open ibanos90 opened 2 years ago

ibanos90 commented 2 years ago

Description This PR fixes an issue that was found when neither the do_thinning or do_superob options were set as true in the namelist for the goes-abi_converter. Here, the do_thinning option is removed, allowing do_superob to control whether superobbing or thinning is performed. The default option is no superobbing and the number of pixels to skip is controlled by the user defined n_subsample parameter via namelist. If n_subsample is equal to 1, then no thinning is done and all pixels are kept. The README.md files for the ABI namelist and AHI converter usage are also updated to include more accurate information for users. A small bug was also fixed in the code for thinning AHI observations.

Thank you @gthompsnJCSDA for pointing out this issue in the code.

ibanos90 commented 2 years ago

@gthompsnJCSDA Could you please provide a review for this bug fix? For some reason I can't add you in the Reviewers section.

jjguerrette commented 2 years ago

@ibanos90, did you compile and run this version? Please say so in the PR comment and mention how the output is verified, like visual inspection using ncdump or some other method.