search

NCAR / obs2ioda

Converter developed by @jamiebresch to transform conventional and remote sensing observations in different formats to the IODA format needed in JEDI
4 stars 4 forks source link

obs2ioda fails to process himawari HSD data #7

Closed mrixlam closed 1 month ago

mrixlam commented 1 month ago

I tried to read and convert HSD binary data for himawari 8 (available here: /glade/derecho/scratch/mrislam/work/pandac/radiance_data_processing/obs_ioda/work/input) but it did not work as expected.

I used the following command: "./obs2ioda-v2.x -i input/ -ahi -t 201801010000", as suggested by the readme file: https://github.com/jamiebresch/obs2ioda/blob/main/obs2ioda-v2/README.md.

I tried both the obs2ioda.x (from obs2ioda-v1) and obs2ioda-v2.x (from obs2ioda-v2) built in the following directory (/glade/derecho/scratch/mrislam/work/pandac/radiance_data_processing/obs2ioda) gave me the exact same error message.

forrtl: severe (71): integer divide by zero Image PC Routine Line Source
libpthread-2.31.s 000014FA32DF28C0 Unknown Unknown Unknown obs2ioda-v2.x 0000000000411605 Unknown Unknown Unknown obs2ioda-v2.x 000000000041F659 Unknown Unknown Unknown obs2ioda-v2.x 0000000000402C8D Unknown Unknown Unknown libc-2.31.so 000014FA32A1C29D __libc_start_main Unknown Unknown obs2ioda-v2.x 0000000000402BBA Unknown Unknown Unknown

Screenshot:

Screenshot 2024-06-04 at 7 27 37 AM
byoung-joo commented 1 month ago

Hi @mrixlam ,

Please add -s 1 (subsampling) to your command OR use the recently (?) added superobbing options (https://github.com/NCAR/obs2ioda/pull/4).

mrixlam commented 1 month ago

Hi @byoung-joo thanks for looking into this issue.

With subsampling, the command works and I was able to generate a HDF formatted data. Since the use of subsampling option is required, I suggest that we remove the following sentence from obs2ioda's readme.md file:

"Number of pixels to skip is optional."

byoung-joo commented 1 month ago

Since the use of subsampling option is required, I suggest that we remove the following sentence from obs2ioda's readme.md file:

"Number of pixels to skip is optional."

@mrixlam , please open a PR here when you are ready.
I think this repository is a right place. Can you confirm this, @ibanos90 ?

ibanos90 commented 1 month ago

Since the use of subsampling option is required, I suggest that we remove the following sentence from obs2ioda's readme.md file: "Number of pixels to skip is optional."

@mrixlam , please open a PR here when you are ready. I think this repository is a right place. Can you confirm this, @ibanos90 ?

Yes, here is the right place. Thanks @byoung-joo for looking into this! I thought this variable had a default value (i.e., 1 for no skipping any value), which may be better in this case. By doing that, we can keep the comment in the Readme but specify this value in the script. What do you think @byoung-joo?

byoung-joo commented 1 month ago

I agree, that (setting the default value of 1 for subsample)would work, too!

mrixlam commented 1 month ago

Okay, I will open a PR for this modification. Thanks @ibanos90 and @byoung-joo for your help in fixing this issue for me, and future users.