search

NCAR / pynio

PyNIO is a multi-format data I/O package with a NetCDF-style interface
http://www.pyngl.ucar.edu/Nio.shtml
Apache License 2.0
112 stars 37 forks source link

Rebase ncl-update onto develop to update backend NCL code #28

Closed rcabell closed 5 years ago

rcabell commented 5 years ago

Fixes #21 by simply rebasing the new NCL code from the ncl-update branch onto the develop branch. Tested locally on my system for my specific use case, which works, but I don't see a Python 3-specific module in the test directory to run any sanctioned unit/regression tests.

bladwig1 commented 5 years ago

While there are no specific python 3 test scripts, you can run the *.py files in there manually. Can you run the .py files and make sure they don't have any segfaults or other problems? The code that is being merged has a lot of changes to the hdf5 stuff, and this is where there are likely to be problems. If you can run the .py files, then I'll go ahead and merge the PR. Thanks!

rcabell commented 5 years ago

I've run all the *.py files in the test directory with no (obvious) errors. Output is attached.

py3_test_output.txt

bladwig1 commented 5 years ago

Thanks!