NCAR / python-tutorial

Online content for self-paced Python tutorial
https://ncar.github.io/python-tutorial/
2 stars 7 forks source link

Revert "Info from tutorial recordings" #50

Closed jukent closed 3 years ago

jukent commented 3 years ago

Reverts NCAR/python-tutorial#49

Place holder PR while we figure out why the merge from @kmpaul failed while passing all tests. These two errors appear in the deploy/Instal SSH client step:

jukent commented 3 years ago

Related to this deprecation - https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

jukent commented 3 years ago

I know the changes need to be made to github/workflows/ghpages.yml but it isn't immediately obvious to me how to fix the issues to address the new security levels. I will look more when we get back to work next Monday.

kmpaul commented 3 years ago

@jukent: So, it turns out all we had to do was update the GitHub Action versions (namely the webfactory/ssh-agent@v0.2.0 to webfactory/ssh-agent@v0.4.1). I made this change to the master branch, which means we don't have to revert the previous PR. So, I am going to close this PR.