search

NCAR / python-tutorial

Online content for self-paced Python tutorial
https://ncar.github.io/python-tutorial/
2 stars 7 forks source link

Adding publish your package content. #62

Closed jukent closed 3 years ago

jukent commented 3 years ago

And making a few changes to previous content based on recent GitHub changes.

jukent commented 3 years ago

@kmpaul Could you take a look at the new content? So far I have the skeleton of the steps and some of the ideas I should talk about written down. But, I've never actually published a package to PyPi and know that some of my explanations need to be fleshed out. I could use some help making sure I don't misrepresent any aspect of this.

kmpaul commented 3 years ago

Sure. I'll take a look. I might not have time today or this weekend though.

jukent commented 3 years ago

Sure. I'll take a look. I might not have time today or this weekend though.

I understand. Don't let it eat into your free time :) The tutorial is coming up but we have enough time to polish everything within regular working hours.

kmpaul commented 3 years ago

@jukent: Ok, you should pull the changes that I made into your repo (just execute git pull) and take a look at it.

kmpaul commented 3 years ago

@jukent: Ok. I've tested my changes and I can't find any obvious errors or typos, but you should read through it since there are a lot of changes. What do you think?

jukent commented 3 years ago

@jukent: Ok. I've tested my changes and I can't find any obvious errors or typos, but you should read through it since there are a lot of changes. What do you think?

Great thanks! I just got to this section of my script writing (a.k.a very deliberate run through) so this is perfect timing to do a thorough check of these changes. I should be able to get back with a review on this by the end of the day today or early tomorrow.

jukent commented 3 years ago

I'm not sure why, but I find that language confusing. Does "at the same level as" make sense to you? Or, we could be very clear and say, "within your :code:python_tutorial directory"?

I don't want to leave any room for confusion either. I changed it to: "Create a setup.py file one level above your mysci package (in the python_tutorial directory)"