search

NCAR / python-tutorial

Online content for self-paced Python tutorial
https://ncar.github.io/python-tutorial/
2 stars 7 forks source link

Using raw html blocks instead of seperate youtube blocks for video embedding #71

Closed jukent closed 3 years ago

jukent commented 3 years ago

There was an issue where the deployed site was not displaying the embedded youtube videos even though they deployed locally (from PR #69)

I think that this method (using ..raw:: html blocks instead of new .. youtube:: blocks) is simpler and thus less likely to have an error.

jukent commented 3 years ago

@kmpaul Since I am out Monday and Tuesday but would like this fixed ASAP feel free to merge if you approve the changes.

jukent commented 3 years ago

I think we need to add a deployment test to our PRs since there seems to be a discrepancy between how things are building locally and how they deploy in this regard.