NCAR / tuv-x

Photolysis rate constant calculator
https://ncar.github.io/tuv-x/
Apache License 2.0
4 stars 2 forks source link

Add regression test for C++ Delta Eddington solver #85

Closed mattldawson closed 5 months ago

mattldawson commented 5 months ago

Adds a test of the new stub C++ Delta Eddington solver against the existing Fortran-based solver using the TUV 5.4 example conditions.

Notes:

closes #66

sjsprecious commented 5 months ago

@mattldawson I ran your latest branch on Derecho with GNU compiler and got the following failed tests:

         73 - regression_photolysis_rates (Failed)
         74 - regression_dose_rates (Failed)
         75 - regression_aerosols_radiator (Failed)
         76 - regression_aerosols_radiator_4strm (Failed)
         77 - regression_o2_radiator (Failed)
         78 - regression_o2_radiator_4strm (Failed)
         79 - regression_o3_radiator (Failed)
         80 - regression_o3_radiator_4strm (Failed)
         81 - regression_rayleigh_radiator (Failed)
         82 - regression_rayleigh_radiator_4strm (Failed)
         83 - regression_all_radiators (Failed)
         84 - regression_all_radiators_4strm (Failed)

Are these failures expected?

sjsprecious commented 5 months ago

egression_photolysis_rates

According to Matt, all the failed regression tests are due to the missing of loading conda module on Derecho, which we won't worry about it at this moment.