search

NCAR / ucomp-pipeline

Data processing pipeline for UCoMP
Other
6 stars 3 forks source link

How should the pipeline mean/median combination handle observing programs in which the continuum location CONTIN changes? #224

Open bberkeyU opened 11 months ago

bberkeyU commented 11 months ago

I think the L1 pipeline correctly checks that the CONTIN keyword for an L0 file remains constant before co-adding wavelengths. But what should the pipeline do if we had an observing program that took data

CONT_CHANGE.CBK
1074_3wavelenghts_red.rcp
1074_3wavelenghts_blue.rcp
1074_3wavelenghts_both.rcp
1074_3wavelenghts_red.rcp
1074_3wavelenghts_blue.rcp
1074_3wavelenghts_both.rcp
1074_3wavelenghts_red.rcp
1074_3wavelenghts_blue.rcp
1074_3wavelenghts_both.rcp

If we allow this to happen, the pipeline should produce three mean files for the CONT_CHANGE program, with one average for each of the red, blue, and continuum tunings. Based on our L2 file naming scheme, I don't think the pipeline can do this. I assume it will average together all 3 flavors, which is probably the wrong thing to do.

What should we have the pipeline do in this case? Is it worth addressing if no one ever creates this observing program?

StevenTomczyk commented 11 months ago

I think we should definitely allow continuum changes to be made during a recipe. It is OK to average them in the pipeline, in fact it might average out systematic errors.

bberkeyU commented 11 months ago

I dont think the l1 pipeline currently averages data with different continuum locations. But if it did what should it document in contin?

StevenTomczyk commented 11 months ago

How about "red blue" or "red blue both"