search

NCAR / ucomp-pipeline

Data processing pipeline for UCoMP
Other
6 stars 3 forks source link

Probably grouping FITS extensions by the wrong metrics #24

Closed bberkeyU closed 1 year ago

bberkeyU commented 2 years ago

In src/level1/ucomp_l1_average_data.pro line 36 we start doing a group by EXPTIME, ONBAND, WAVELNG.

We probably don't need to include EXPTIME in here. Operationally it takes a considerably long time to change the exposure for the camera, and we would likely want to take darks after doing the exposure change; so it is very unlikely that we will make exposure changes will in a fits file for any science data. However, if we are including EXPTIME we probably want to include the continuum (RED,BLUE,BOTH). This is a very inexpensive change to make in the instrument tuning, so at some point, I expect we could encounter a program especially in the chromosphere where we don't have a good continuum due to line width where we vary the continuum location within a single FITS file.

bberkeyU commented 2 years ago

If we keep EXPTIME we should also add in GAIN; because at least in 1083 we are at least as likely to change the gain as we are the exp time.

mgalloy commented 1 year ago

GAIN is set in the primary header, so it is not possible to change by extension. CONTIN is an extension keyword.