search

NCAR / watershed_tools

Methods for creating watershed discretizations for use in hydrological modeling or analysis. Examples use the SUMMA modeling Framework.
GNU General Public License v3.0
11 stars 5 forks source link

prepare_initial_basin_shapefiles comments #9

Open DaveCasson opened 2 years ago

DaveCasson commented 2 years ago

This issue intended to keep code issues and comments from the test run.

To use with MERIT-Hydro, the catchment and river network data files need to be merged on COMID to create the input for this processing workflow. Can discuss adding this as preprocessing option. Something like fulldom_gru_shp = fulldom_gru_shp .merge(flowlines_shp, on=COMID')

ln 25: from rasterio.warp import Resampling not used

ln 92: I needed to add: int() to outlet_gruId = int(ut.read_from_control(control_file, 'basin_outlet_gruId'))

In geospatial_analysis.py ogr is imported, but not used except in reproject_basin_shapefile, but here the variable it creates is not used. Suggest removing. I mention as would expect 'from osgeo import ogr'

andywood commented 2 years ago

My application so far has been in starting with a shapefile that is for the basin I want, rather than extracting it from a larger catchment dataset, so I haven't looked in detail at the part that extracts it given a comid, which I typically do using a separate script. But I think we should make sure this works. We don't want to hardwire it to the MERIT case, though, or even to one in which the IDs are ints vs strings.

Good to strip out any unused imports ...