Restructuring repo - Githubissues

NCAR / wrf-python

A collection of diagnostic and interpolation routines for use with output from the Weather Research and Forecasting (WRF-ARW) Model.

https://wrf-python.readthedocs.io

Apache License 2.0

402 stars 152 forks source link

Restructuring repo #150

Closed erogluorhan closed 3 years ago

erogluorhan commented 3 years ago

Remove CircleCI configurations
Add Github Actions workflow instead (.github/workflows/ci.yml)
Restructure folders and env files (move into folder build_envs, and remove some unnecessary env files such as testenv2.yml) and modifie some docs in relation.

erogluorhan commented 3 years ago

@michaelavs FYI: The failing CI tests below are from the removed CircleCI configuration, and we are intorudcing several Github actions instead, which are passing in this PR. So, the failing CircleCI tests shouldn't be an issue (and they won't appear anymore in the future PRs):

erogluorhan commented 3 years ago

I'm not very familiar with this repo, but it looks like everything is working from my end.

Thanks! Yes, CircleCI build tests are replicated in the new ci.yml and these tests all pass.

My only question is whether /test/ci_tests/ can also be removed since circleci was replaced.

No, it shouldn't be removed because it is for general CI testing, nothing specific to CircleCI. You can see that it is used in .github/workflows/ci.yml in the last step "Run tests"

anissa111 commented 3 years ago

Ah! That makes sense