Fix handling of config for third party packages

NCAR / wrf-python

A collection of diagnostic and interpolation routines for use with output from the Weather Research and Forecasting (WRF-ARW) Model.

https://wrf-python.readthedocs.io

Apache License 2.0

410 stars 155 forks source link

Fix handling of config for third party packages #169

Closed sfalmo closed 2 years ago

sfalmo commented 2 years ago

Fix #168

There were some typos which led to wrong boolean values and a broken config mechanism. Now the config works again and it is ensured that a third party package is only enabled if it is installed.

michaelavs commented 2 years ago

@erogluorhan Would you mind looking this over? I believe everything looks good, but just want to be sure!

erogluorhan commented 2 years ago

I successfully built and ran wrf-python with these updates and had the correct values returned. So, I am approving this PR in it's current state

Sounds good!