search

NCAR / wrf-python

A collection of diagnostic and interpolation routines for use with output from the Weather Research and Forecasting (WRF-ARW) Model.
https://wrf-python.readthedocs.io
Apache License 2.0
402 stars 152 forks source link

Add alias for mcape and mcin #195

Closed fedecutraro closed 1 year ago

fedecutraro commented 1 year ago

As I commented in #194 calling variables mcape and mcin in getvar function gives an error. I added the alias for those variables to make it work.

erogluorhan commented 1 year ago

I am currently trying to figure out why this PR not triggered the gitHub Actions checks

erogluorhan commented 1 year ago

Hi @fedecutraro , could you please push an empty commit just to get GitHubA Actions checks triggered? You can do it by:

git commit --allow-empty -m "Empty-Commit to trigger GitHub Actions checks"

fedecutraro commented 1 year ago

@erogluorhan I've just made the empty commit.

This is the first time I'm doing a pull request, maybe I forgot to do something?

erogluorhan commented 1 year ago

@erogluorhan I've just made the empty commit.

This is the first time I'm doing a pull request, maybe I forgot to do something?

No, it was not because of that! The automated GitHub Actions checks weren't triggered for some reason, but now after your empty commit, we got them triggered successfully. As we got that now, I will provide my review about the code as soon as I can.

Thanks very much for your contribution!