search

NCAR / wrf-python

A collection of diagnostic and interpolation routines for use with output from the Weather Research and Forecasting (WRF-ARW) Model.
https://wrf-python.readthedocs.io
Apache License 2.0
392 stars 149 forks source link

Pin numpy version to avoid bug which impacts array ordering #211

Closed kafitzgerald closed 1 year ago

kafitzgerald commented 1 year ago

Pin numpy version (!= 1.24.3) to avoid bug which impacts array ordering in requirements and conda build envs.

I also removed the conda_recipe directory rather than updating the meta.yml in there since that content now lives in the feedstock repo and seems to be duplicative and a bit out of date.

Relatedly, this change will also need to be made in the wrf-python conda-forge feedstock repo. I'll log an issue there and can submit a PR, but that one might need a closer look.

While looking into this issue, I also noticed our testing doesn't appear to be keeping up with the versions we're releasing on conda-forge (i.e. it looks like we're only testing Python 3.10 w/ through CI, but doing Python 3.11 releases). I'll log an issue to update testing as well.

Closes #207.

erogluorhan commented 1 year ago

Relatedly, this change will also need to be made in the wrf-python conda-forge feedstock repo. I'll log an issue there and can submit a PR, but that one might need a closer look.

While looking into this issue, I also noticed our testing doesn't appear to be keeping up with the versions we're releasing on conda-forge (i.e. it looks like we're only testing Python 3.10 w/ through CI, but doing Python 3.11 releases). I'll log an issue to update testing as well.

Thanks for catching these! I will be looking out for them and helping out if needed

kafitzgerald commented 1 year ago

Confirmed the tests pass on 1.25.0rc1 so I'm going to leave this with just the negation.