search

NCAR / wrf_hydro_docker

Docker containers for the WRF-Hydro modeling system
https://hub.docker.com/u/wrfhydro
22 stars 24 forks source link

Pocono / RFC training container #95

Closed rcabell closed 5 years ago

rcabell commented 5 years ago

New training container that includes the Pocono NWM configuration. This Dockerfile clones/downloads at image build time vs container run time, to better support environments that have poor/no internet connectivity.

kafitzgerald commented 5 years ago

There are also some build and deploy shell scripts in the main directory that should probably be updated or we could potentially just remove the training containers from those too if that makes more sense.

I imagine these were written by Joe or @jmccreight. Not sure if James has opinions. I'm just going for "don't break things."

rcabell commented 5 years ago

There are also some build and deploy shell scripts in the main directory that should probably be updated or we could potentially just remove the training containers from those too if that makes more sense.

I imagine these were written by Joe or @jmccreight. Not sure if James has opinions. I'm just going for "don't break things."

I'm not using the build scripts myself; just docker build -t <repo/name:tag> . but it doesn't seem like it hurts to leave them there for now...

rcabell commented 5 years ago

Nit picky: we are using v5.1.0, but several commands and text refers to v.5.0.x, e.g. docker run --name wrf-hydro-training -p 8888:8888 -it wrfhydro/training:v5.0.x . Not a big deal but did notice it.

I'm going to change it to use v2.0 for the NWM-specific container, so issue will resolve implicitly.

kafitzgerald commented 5 years ago

@rcabell @laurareads as far as I can see it looks like there are still some (editorial) changes to be made to the README, but otherwise things look good. Do you want these as suggestions now or shoudl we merge and run through those separately?

laurareads commented 5 years ago

Whatever you think is the easiest way - I'm fine if you want to merge them.

On Tue, Apr 30, 2019 at 5:45 PM Katelyn FitzGerald notifications@github.com wrote:

@rcabell https://github.com/rcabell @laurareads https://github.com/laurareads as far as I can see it looks like there are still some (editorial) changes to be made to the README, but otherwise things look good. Do you want these as suggestions now or shoudl we merge and run through those separately?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NCAR/wrf_hydro_docker/pull/95#issuecomment-488154218, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIEXYNN7P7OXAQL42YBIM3PTDKZVANCNFSM4HIPATFA .

-- Laura Read NCAR Research Applications Laboratory lread@ucar.edu Office: 303-497-8391