search

NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

RFC Forecasts Module Updates #446

Closed jdmattern closed 4 years ago

jdmattern commented 4 years ago

TYPE: enhancement

KEYWORDS: Reservoir Module, RFC Forecasts, Water Management

SOURCE: David Mattern - NOAA, @jdmattern-noaa

DESCRIPTION OF CHANGES: Updates to the algorithms in RFC Forecasts Module and splitting the reservoir observations path into USGS and USACE reservoir observations paths read from namelist.

ISSUE: Fixes #445

TESTS CONDUCTED: Unit tests and 3-day CONUS tested and evaluated.

Checklist

kafitzgerald commented 4 years ago

Looks good to me overall. I did see a cfs in the comments that should be cms and I think that peak flow threshold is a little low. According to USGS Vicksburg saw 2.3 million cfs in 2011.

The current threshold of 1.4 million cfs x2 (safety factor) is being used to check reservoir output forecasts though so the lower threshold might be more than fine. @laurareads thoughts?

laurareads commented 4 years ago

Yes, I think the threshold that Mattern implemented was copied from the nudging code. We could adjust up - Fernando had asked about this. Would we want to do it in the nudging code as well?

On Fri, Feb 7, 2020 at 2:40 PM Katelyn FitzGerald notifications@github.com wrote:

Looks good to me overall. I did see a cfs in the comments that should be cms and I think that peak flow threshold is a little low. According to USGS https://nwis.waterdata.usgs.gov/ms/nwis/peak?site_no=07289000&agency_cd=USGS&format=html Vicksburg saw 2.3 million cfs in 2011.

The current threshold of 1.4 million cfs x2 (safety factor) is being used to check reservoir output forecasts though so the lower threshold might be more than fine. @laurareads https://github.com/laurareads thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NCAR/wrf_hydro_nwm_public/pull/446?email_source=notifications&email_token=AFIEXYLN5M5XCEEJ43B5A4DRBXIMZA5CNFSM4KOLDJQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELEW6OY#issuecomment-583626555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFIEXYKIFJSUE4NR7TYTF63RBXIMZANCNFSM4KOLDJQQ .

-- Laura Read NCAR Research Applications Laboratory lread@ucar.edu Office: 303-497-8391

jdmattern commented 4 years ago

Good find and thanks, Katelyn. Once we settle on a CMS amount, we would also need to change this check in the USGS/USACE reservoir timeslice reader here:

https://github.com/NCAR/wrf_hydro_nwm_public/blob/master/trunk/NDHMS/Routing/Reservoirs/module_reservoir_read_timeslice_data.F#L310