search

NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

Update all code to be conformant with Fortran 2008 #490

Open kafitzgerald opened 4 years ago

kafitzgerald commented 4 years ago

For reference:

Folks,

We are going down the path to be strictly conformant with Fortran 2008. I will be sending some emails about this. We can't have integer4, integer8, real4, or real8. Those are fortran 77 extensions. The proper syntax is integer(kind=4), integer(kind=8), real(kind=4), real(kind=8).

For a listing of the offending files: find . -name \*.F -exec grep -i 'integer\*4' {} \; -print and so on for the others.

You each only need to worry about YOUR codes, the subdirectories of var, wrftladj, chem, or hydro. I'll do the shared code. I assume there will be other nonstandard issues that pop up, and I'll send those along as well.

Instead of trying to get too organized, everyone can do their own PRs (for example, we will not have a single big group PR that handles lines that are too long throughout the entire model).

Dave

May want to use iso_fortran_env instead...