DESCRIPTION OF CHANGES: Levelpool module was modified to add different shape options for reservoir simulations. Several module files were modified to read new variables from LAKEPARM file (LkVol, LkMxDepth, poly_a, and poly_b) and pass to module "module_levelpool.F". A new subroutine (STAGE_STORAGE) was also added to module module_levelpool.F. "hydro.namelist" was also modified to change shape options as follows:
! lake_shape_option options:
! 0=BOX shape with depth based on active reservoir depth (NWM v1.x - v2.1)
! 1=CONIC shape with depth based on full lake depth
! 2=RECTANGLUAR PRISM shape with depth based on full lake depth
! 3=H-A-V RELATIONSHIP depth based on full lake depth
lake_shape_option = 0
TESTS CONDUCTED: Different shape options were tested with Croton domain. lake_shape_option=0 is supposed to be similar with NWM v.2.1. The two versions of the code (NWM v2.1 and modified version with lake_shape_option=0) produced the same results. Shape options 1-3 also tested and results were reasonable and met the expectations.
Checklist
Merging the PR depends on following checklist being completed. Add X between each of the square
brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment
on why below the bullet.
[ ] Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
[X] Tests added (unit tests and/or regression/integration tests)
Differnet shape options tested for the Croton domain.
[ ] Backwards compatible
[X] Requires new files? If so, how to generate them.
Working LAKPEARM file: /glade/work/bkhazaei/croton52/levelpool3_test/DOMAIN/LAKEPARM_croton_LP3_obs_depth_30m.nc
Working hydro.namelist file: /glade/work/bkhazaei/croton52/levelpool3_test/hydro.namelist
[ ] Fully documented
[ ] Short description in the Development section of NEWS.md
TYPE: new feature
KEYWORDS: reservoir parametrization, levelpool, reservoir shape options
SOURCE: Bahram, NCAR
DESCRIPTION OF CHANGES: Levelpool module was modified to add different shape options for reservoir simulations. Several module files were modified to read new variables from LAKEPARM file (LkVol, LkMxDepth, poly_a, and poly_b) and pass to module "module_levelpool.F". A new subroutine (STAGE_STORAGE) was also added to module module_levelpool.F. "hydro.namelist" was also modified to change shape options as follows:
! lake_shape_option options: ! 0=BOX shape with depth based on active reservoir depth (NWM v1.x - v2.1) ! 1=CONIC shape with depth based on full lake depth ! 2=RECTANGLUAR PRISM shape with depth based on full lake depth ! 3=H-A-V RELATIONSHIP depth based on full lake depth lake_shape_option = 0
TESTS CONDUCTED: Different shape options were tested with Croton domain. lake_shape_option=0 is supposed to be similar with NWM v.2.1. The two versions of the code (NWM v2.1 and modified version with lake_shape_option=0) produced the same results. Shape options 1-3 also tested and results were reasonable and met the expectations.
Checklist
Merging the PR depends on following checklist being completed. Add
Xbetween each of the square brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment on why below the bullet.NEWS.md