search

NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

Add Cray Fortran compiler support #539

Closed rcabell closed 3 years ago

rcabell commented 3 years ago

TYPE: bug fix / enhancement

KEYWORDS: cray, fortran

SOURCE: WRF-Hydro Internal

DESCRIPTION OF CHANGES: Add support for Cray Fortran and Intel Fortran compilers on Cray systems by fixing the existing Cray-Intel macros file and adding a new Cray Fortran macros file.

ISSUE: 

Fixes #538 Support Cray Fortran compilers

TESTS CONDUCTED: Code now builds on Cray systems using both Intel Fortran and Cray Fortran

NOTE: This PR goes hand-in-hand with #540, which addresses specific places in the code where deviations from the official Fortran standard are allowed by the Intel and GNU Fortran compilers but not by the Cray Fortran compiler.

Checklist

Merging the PR depends on following checklist being completed. Add X between each of the square brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment on why below the bullet.

rcabell commented 3 years ago

As an additional note, this PR does not add Cray Fortran support to the CMake build system, which is still limited to Intel and GNU Fortran. Not sure if this is worth a separate issue...