NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

Move overland roughness assignment out of time cycling disaggregation routine #553

Closed aubreyd closed 2 years ago

aubreyd commented 3 years ago

TYPE: enhancement

KEYWORDS: overland, parameters

SOURCE: Aubrey D, NCAR

DESCRIPTION OF CHANGES: The overland roughness parameter is being setup on the high-res grid in the disaggregation routine, but this routine is called every LSM timestep and the overland roughness parameter is not time-varying. It should be moved into the initialization routine.

ISSUE: The GitHub Issue that this PR addresses. For issue number 123, it would be:

Fixes #123

TESTS CONDUCTED: Gives identical solution to pre-change on 1 core. DOES NOT CURRENTLY PASS NCORES... (help!).

Checklist

scrasmussen commented 3 years ago

Just wanted to say that I've been able to reproduce that one core gives an identical solution and more than one core doesn't. I'm currently looking into the issue and will try to get it fixed as soon as possible! (First real deep dive into the code base so taking longer than expected)