Remove requirement for gridded groundwater basins IDs to follow the 1,...,n convention

NCAR / wrf_hydro_nwm_public

WRF-Hydro model code

https://ral.ucar.edu/projects/wrf_hydro

Other

178 stars 138 forks source link

Remove requirement for gridded groundwater basins IDs to follow the 1,...,n convention #554

Open kafitzgerald opened 3 years ago

kafitzgerald commented 3 years ago

It's currently an (unwritten) requirement for the groundwater IDs in the gridded model configuration to follow a 1,...,n convention.

While the standard method of generating the basin files follows this convention, it ends up being problematic for running gridded domain subsets and calibrations.

Offending code here: https://github.com/NCAR/wrf_hydro_nwm_public/blob/df784c8a55172c9da390a4d81ad6e888cd8d4a2a/trunk/NDHMS/Routing/module_HYDRO_io.F#L1341

kafitzgerald commented 3 years ago

I can take a look at this when I get a chance, but if someone else has a chance go for it.

@arezoorn brought this to my attention and it sounds like it's come up now in a couple of active projects.