NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

Exposed NoahMP swe limit parameter and snow bug fix for large packs #584

Closed aubreyd closed 2 years ago

aubreyd commented 3 years ago

TYPE: bug fix, enhancement

KEYWORDS: NoahMP, snow, parameters

SOURCE: Aubrey D, NCAR

DESCRIPTION OF CHANGES: 1) NoahMP snow model had a hard-coded SWE cap (initially 2m, upped to 5m). I just exposed this cap to a user-defined parameter in MPTABLE global parameter section. 2) Fix for energy NAs over large snowpacks due to very small numbers being rounded to 0, so number/number=NA instead of 1. Switched to an if statement.

TESTS CONDUCTED: Tested with NWM-Alaska domain. Limit value change experiments behave as expected. Bug fix also tested with NWM-Alaska.

NOT BACKWARD COMPATIBLE! Requires updated MPTABLE. Code should crash if new parameter not present.