NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

Add priority snow parameters to 2d parameter file and add new scamax param #594

Closed aubreyd closed 2 years ago

aubreyd commented 2 years ago

TYPE: enhancement

KEYWORDS: NoahMP, snow, parameters

SOURCE: Aubrey D, NCAR

DESCRIPTION OF CHANGES:

  1. Add 4 snow model parameters (ssi, snowretfac, tau0, rsurfsnow) to 2d soil_properties file so we can vary in space. These parameters were already exposed in MPTABLE.
  2. Create a new "scamax" parameter to put an upper bound on fSCA in the snow depletion curve. This parameter can vary from 0 to 1 (scaler applied to the fSCA upper bound), but use lower values with caution as they may not make physical sense. Default value for new parameter is 1.0 and will reproduce previous model behavior. This work was contributed by Tom Enzminger, NCAR (@then6702 )

ISSUE: N/A

TESTS CONDUCTED: Tested with NWMv2.1 CONUS domain and confirmed:

  1. Running with default parameter values with both SPATIAL_SOIL = 0 and 1 reproduce master results
  2. Varying new parameters in MPTABLE and soil_properties change the solution in expected ways

NOTES: This code update requires new parameter files if running with SPATIAL_SOIL=1. Should have no answer changes if running with default parameter values.

Checklist

then6702 commented 2 years ago

The physics updates look correct to me

rcabell commented 2 years ago

PR passes CONUS-AnA on Cheyenne but LR currently unavailable.