search

NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

Channel NaN fixes for Muskingum-Cunge #599

Closed aubreyd closed 2 years ago

aubreyd commented 2 years ago

TYPE: bug fix

KEYWORDS: channel, streamflow, muskingum-cunge

SOURCE: Aubrey D, NCAR

DESCRIPTION OF CHANGES: Add extra checks to prevent divide by 0 in Muskingum-Cunge solution. With @dnyates.

ISSUE: #598

TESTS CONDUCTED: Tested NWM-CONUS for 2 years with v3.0 draft channel parameters, including 0 compound channel width reaches. No NaNs occurred after fixes.

NOTES: May pass regression with standard channel parameters.

Checklist

Merging the PR depends on following checklist being completed. Add X between each of the square brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment on why below the bullet.

dnyates commented 2 years ago

do you need some chimes here?

On Thu, Apr 21, 2022 at 8:25 AM Aubrey Dugger @.***> wrote:

@.**** commented on this pull request.

In trunk/NDHMS/Routing/module_channel_routing.F https://github.com/NCAR/wrf_hydro_nwm_public/pull/599#discussion_r855246777 :

@@ -266,7 +266,7 @@ subroutine SUBMUSKINGCUNGE( &

        Twl = Bw + 2.0*z*h_0      !--top surface water width of the channel inflow
  • if(h_0 .gt. bfd) then !water outside of defined channel
  • if ( (h_0 .gt. bfd) .and. (TwCC .gt. 0.0) .and. (nCC .gt. 0.0) ) then !water outside of defined channel

I'm checking with the team who set this up... my understanding is that compound channel width = 0 means an infinitely tall standard trapezoidal channel.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/wrf_hydro_nwm_public/pull/599#discussion_r855246777, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGRZSIDZ7OWEHGUSY2BLX3VGFQOVANCNFSM5L2USTOQ . You are receiving this because you were assigned.Message ID: @.***>

--

David Yates NCAR 303.497.8394 (o) 303.809.6604 (m)

aubreyd commented 2 years ago

Yes! I also pinged for input on Slack... either way.

On Thu, Apr 21, 2022 at 9:24 AM dnyates @.***> wrote:

do you need some chimes here?

On Thu, Apr 21, 2022 at 8:25 AM Aubrey Dugger @.***> wrote:

@.**** commented on this pull request.

In trunk/NDHMS/Routing/module_channel_routing.F < https://github.com/NCAR/wrf_hydro_nwm_public/pull/599#discussion_r855246777

:

@@ -266,7 +266,7 @@ subroutine SUBMUSKINGCUNGE( &

Twl = Bw + 2.0zh_0 !--top surface water width of the channel inflow

  • if(h_0 .gt. bfd) then !water outside of defined channel
  • if ( (h_0 .gt. bfd) .and. (TwCC .gt. 0.0) .and. (nCC .gt. 0.0) ) then !water outside of defined channel

I'm checking with the team who set this up... my understanding is that compound channel width = 0 means an infinitely tall standard trapezoidal channel.

— Reply to this email directly, view it on GitHub < https://github.com/NCAR/wrf_hydro_nwm_public/pull/599#discussion_r855246777 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADGRZSIDZ7OWEHGUSY2BLX3VGFQOVANCNFSM5L2USTOQ

. You are receiving this because you were assigned.Message ID: @.***>

--

David Yates NCAR 303.497.8394 (o) 303.809.6604 (m)

— Reply to this email directly, view it on GitHub https://github.com/NCAR/wrf_hydro_nwm_public/pull/599#issuecomment-1105376433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7CTG3EEZESMKTSX4M34PLVGFXLHANCNFSM5L2USTOQ . You are receiving this because you were mentioned.Message ID: @.***>

--

Aubrey Dugger NCAR Research Applications Laboratory Office: 303-497-8418, Cell: 310-663-5115 @.***