hydro.namelist check inconsistent with selected options

[laurareads]

The output options for output_channelBucket_influx = 0 state that these are only active for UDMP_OPT=1, however, the following is noted:

Current Behavior

If UDMP_OPT=0 and output_channelBucket_influx = 2 with GWBASESWCRT = 0, the model crashes since these options are inconsistent. This is GOOD because GWBASESWCRT cannot be zero if a user wants 2=channel+bucket fluxes (qSfcLatRunoff, qBucket, qBtmVertRunoff_toBucket)

Expected Behavior

The comment in the hydro.namelist, ! Options to output channel & bucket influxes. Only active for UDMP_OPT=1. , makes it seem like this entire suite of options are ignored if UDMP=0, but in reality they are not being ignored.

Possible Solution

Remove this comment from the hydro.namelist: ! Options to output channel & bucket influxes. Only active for UDMP_OPT=1.

Your Environment

• Relevant settings for hydro.namelist: channel_option = 2, UDMP=0, output_channelBucket_influx != 0.
• Using v5 release tag hydro.namelist files with the v5 code tarball, commit: 49e705. Compiled on intel.

[kafitzgerald]

It looks like the channel bucket fluxes (or equivalent) still aren't output when UDMP_OPT=0 so we should probably update the namelist check here (model should fail if this option is non-zero and UDMP_OPT is zero) as well as the documentation (namelist comments).