Crocus output fixes - Githubissues

NCAR / wrf_hydro_nwm_public

WRF-Hydro model code

https://ral.ucar.edu/projects/wrf_hydro

Other

181 stars 139 forks source link

Crocus output fixes #663

Closed aubreyd closed 2 years ago

aubreyd commented 2 years ago

TYPE: enhancement

KEYWORDS: crocus, output

SOURCE: Aubrey D, NCAR

DESCRIPTION OF CHANGES: Update scale values for output variables for Crocus. Fix a few small Crocus issues that were leading to bad values, particularly when cells transition from Crocus to NoahMP.

ISSUE: N/A

TESTS CONDUCTED: Confirmed outputs behaving as expected for NWM-AK crocus active domain. Confirmed perfect restart and ncores tests passed. No answer changes in NWM-CONUS.

Checklist

Merging the PR depends on following checklist being completed. Add X between each of the square brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment on why below the bullet.

[na] Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
[na] Tests added (unit tests and/or regression/integration tests)
[x] Backwards compatible
[na] Requires new files? If so, how to generate them.
[na] Documentation included
[na] Short description in the Development section of NEWS.md

trudeeidhammer commented 2 years ago

I approve all the changes