NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

Classic build system reports successful Make when actually not successful #677

Closed rcabell closed 1 year ago

rcabell commented 1 year ago

When using the classic build system, a build will fail but still report "Make was successful"

Expected Behavior

If the build fails, the message should be "Make NOT succssful"

Current Behavior

Make always reports successful, even if it wasn't

Possible Solution

I'm guessing this is most often due to the change to make; make install in the compile scripts. The first make command fails, but the $? variables gets clobbered by the make install. This should be separated into a make, with a subsequent check, and then if it succeeded, a call to make install.

Steps to Reproduce (for bugs)

  1. Bork something up in the code
  2. Compile
  3. ???
  4. Observe the incorrect message