NCAR / wrf_hydro_nwm_public

WRF-Hydro model code
https://ral.ucar.edu/projects/wrf_hydro
Other
181 stars 139 forks source link

Testing "compiler" options aren't checked for validity #682

Open rcabell opened 1 year ago

rcabell commented 1 year ago

Expected Behavior

Compiler names passed to the testing framework should a) correspond to actual compiler names (gfortran) or b) at least the general suite name used by modules (gnu) and if an invalid item is supplied, the failure in ./configure should be caught instead of letting things fail in byzantine ways later.

Current Behavior

Using gfortran as the compiler name will appear to work at first, but this is passed part-and-parcel to the configure script, which expects gfort and fails (silently, in this case) and then compilation fails later.

Possible Solution

Rename run_tests.py command line option from compiler to configure type or somesuch, or have a reasonable mapping between common compiler names and what configure expects. OR, barring that, catch the error and fail fast with a informative error.

Steps to Reproduce (for bugs)

  1. Run run_tests.py with --compiler gfortran
  2. Watch it fail