NCAR / wrf_hydro_py

Python API for the WRF-Hydro model
59 stars 43 forks source link

Parallel xrcmp and xrnan #190

Closed jmccreight closed 5 years ago

jmccreight commented 5 years ago

This supports https://github.com/NCAR/wrf_hydro_nwm_public/pull/362

  1. Made xrnan variable-wise and parallelizable. (Noted that crazy behavoir happens if you pass a dataset to multiprocessing or if you even leave a dataset open which a multiprocess also opens).

  2. nccmp always for metadata diffs

  3. allow core counts (>1) requested to trigger xrcmp instead of nccmp

  4. I seem to have lost some minor logging changes I made to xrcmp.

pep8speaks commented 5 years ago

Hello @jmccreight! Thanks for updating this PR.

Line 291:13: E722 do not use bare 'except' Line 374:13: E722 do not use bare 'except'

Comment last updated at 2019-09-09 05:55:44 UTC
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 444


Changes Missing Coverage Covered Lines Changed/Added Lines %
wrfhydropy/util/xrnan.py 19 25 76.0%
<!-- Total: 31 37 83.78% -->
Files with Coverage Reduction New Missed Lines %
wrfhydropy/util/xrcmp.py 2 70.77%
wrfhydropy/core/outputdiffs.py 8 74.66%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 441: -0.4%
Covered Lines: 3138
Relevant Lines: 3555

💛 - Coveralls