Closed jmccreight closed 5 years ago
Hello @jmccreight! Thanks for updating this PR.
wrfhydropy/core/outputdiffs.py
:Line 291:13: E722 do not use bare 'except' Line 374:13: E722 do not use bare 'except'
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
wrfhydropy/util/xrnan.py | 19 | 25 | 76.0% | ||
<!-- | Total: | 31 | 37 | 83.78% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
wrfhydropy/util/xrcmp.py | 2 | 70.77% | ||
wrfhydropy/core/outputdiffs.py | 8 | 74.66% | ||
<!-- | Total: | 10 | --> |
Totals | |
---|---|
Change from base Build 441: | -0.4% |
Covered Lines: | 3138 |
Relevant Lines: | 3555 |
This supports https://github.com/NCAR/wrf_hydro_nwm_public/pull/362
Made xrnan variable-wise and parallelizable. (Noted that crazy behavoir happens if you pass a dataset to multiprocessing or if you even leave a dataset open which a multiprocess also opens).
nccmp always for metadata diffs
allow core counts (>1) requested to trigger xrcmp instead of nccmp
I seem to have lost some minor logging changes I made to xrcmp.