pep8speaks
commented
5 years ago Hello @jmccreight! Thanks for opening this PR.
- In the file
wrfhydropy/core/cycle.py:
Line 24:1: E302 expected 2 blank lines, found 1 Line 532:5: E303 too many blank lines (2) Line 538:5: E303 too many blank lines (2) Line 543:28: E251 unexpected spaces around keyword / parameter equals Line 543:30: E251 unexpected spaces around keyword / parameter equals
- In the file
wrfhydropy/core/ensemble.py:
Line 413:28: E251 unexpected spaces around keyword / parameter equals Line 413:30: E251 unexpected spaces around keyword / parameter equals Line 453:25: E128 continuation line under-indented for visual indent
- In the file
wrfhydropy/core/teams.py:
Line 193:21: W291 trailing whitespace Line 213:28: W291 trailing whitespace Line 236:44: E261 at least two spaces before inline comment Line 248:1: W293 blank line contains whitespace Line 250:28: E201 whitespace after '[' Line 250:48: E231 missing whitespace after ',' Line 251:33: E251 unexpected spaces around keyword / parameter equals Line 251:35: E251 unexpected spaces around keyword / parameter equals Line 267:26: E201 whitespace after '[' Line 267:48: E231 missing whitespace after ',' Line 268:1: W293 blank line contains whitespace Line 269:31: E251 unexpected spaces around keyword / parameter equals Line 269:33: E251 unexpected spaces around keyword / parameter equals
- In the file
wrfhydropy/tests/conftest.py:
Line 50:38: E231 missing whitespace after ',' Line 51:45: E231 missing whitespace after ',' Line 51:49: E231 missing whitespace after ':' Line 60:32: E231 missing whitespace after ',' Line 61:49: E231 missing whitespace after ',' Line 61:71: E231 missing whitespace after ',' Line 64:45: E231 missing whitespace after ',' Line 160:1: W293 blank line contains whitespace
- In the file
wrfhydropy/tests/test_cycle.py:
Line 269:9: E124 closing bracket does not match visual indentation Line 279:9: E124 closing bracket does not match visual indentation Line 289:9: E124 closing bracket does not match visual indentation Line 299:5: E124 closing bracket does not match visual indentation Line 1224:26: E251 unexpected spaces around keyword / parameter equals Line 1224:28: E251 unexpected spaces around keyword / parameter equals Line 1225:32: E251 unexpected spaces around keyword / parameter equals Line 1225:34: E251 unexpected spaces around keyword / parameter equals Line 1226:28: E251 unexpected spaces around keyword / parameter equals Line 1226:30: E251 unexpected spaces around keyword / parameter equals Line 1242:17: E131 continuation line unaligned for hanging indent Line 1339:26: E251 unexpected spaces around keyword / parameter equals Line 1339:28: E251 unexpected spaces around keyword / parameter equals Line 1341:32: E251 unexpected spaces around keyword / parameter equals Line 1341:34: E251 unexpected spaces around keyword / parameter equals Line 1342:28: E251 unexpected spaces around keyword / parameter equals Line 1342:30: E251 unexpected spaces around keyword / parameter equals Line 1356:17: E131 continuation line unaligned for hanging indent Line 1363:17: E131 continuation line unaligned for hanging indent Line 1368:13: E124 closing bracket does not match visual indentation
- In the file
wrfhydropy/tests/test_ensemble.py:
Line 428:13: E131 continuation line unaligned for hanging indent Line 431:13: E131 continuation line unaligned for hanging indent
Local linting (style checking) can be peformed using pycodestyle General guidelines can be found at the Hitchhiker's guide to code style
coveralls
This is tested. Passes the collection tests on my osx but not on cheyenne. The outputdiffs tests fail on osx but pass on cheyenne. I still dont understand where the type differences are coming from. I'm going to have to get to the bottom of this soon... already scratched my head a bunch.
Adds functionality for using multiprocess as it an internal scheduler and kicking PBS to the curb after getting the desired resources.
Abstracted the teams used by the ensemble into their own module.
Found a drawback is that when the number of teams is large, the master node load average is perty high. There are probably ways to deal with this but for now it works well enough!