NCAR / wrf_hydro_py

Python API for the WRF-Hydro model
59 stars 43 forks source link

Bugfix/ensemble teams #221

Closed jmccreight closed 4 years ago

jmccreight commented 4 years ago

Ensembles run in parallel again, fixed mistake mergingteams, fix test.

pep8speaks commented 4 years ago

Hello @jmccreight! Thanks for opening this PR.

Line 242:13: E129 visually indented line with same indent as next logical line Line 242:18: E201 whitespace after '[' Line 243:17: E117 over-indented

Line 1228:82: E202 whitespace before ')' Line 1259:18: E131 continuation line unaligned for hanging indent Line 1261:18: E131 continuation line unaligned for hanging indent Line 1263:18: E131 continuation line unaligned for hanging indent Line 1387:14: E131 continuation line unaligned for hanging indent Line 1390:14: E131 continuation line unaligned for hanging indent Line 1393:14: E131 continuation line unaligned for hanging indent

Line 408:96: E202 whitespace before '}' Line 434:1: W293 blank line contains whitespace Line 508:40: W291 trailing whitespace

Line 157:1: W293 blank line contains whitespace

Local linting (style checking) can be peformed using pycodestyle General guidelines can be found at the Hitchhiker's guide to code style

arezoorn commented 4 years ago

I pulled this change and tested on a sample run that I had and the team run is working fine now. So I would say the team run for ensemble run is been fixed with the changes in this pull request.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 591


Changes Missing Coverage Covered Lines Changed/Added Lines %
wrfhydropy/core/ensemble.py 5 6 83.33%
wrfhydropy/core/teams.py 3 4 75.0%
<!-- Total: 40 42 95.24% -->
Totals Coverage Status
Change from base Build 590: 0.1%
Covered Lines: 3746
Relevant Lines: 4265

💛 - Coveralls