NCAR / wrf_hydro_py

Python API for the WRF-Hydro model
59 stars 43 forks source link

Made changes to domain.py to use usgs usage time slice files #223

Closed ishita9 closed 1 year ago

ishita9 commented 4 years ago

In order to use USGS-USACE reservoir files, I first needed to update the hydro_namelist_patches.json file in the CONUS domain dir and added fields in the hydro_nlist:

            "reservoir_usgs_timeslice_path": "./NWM/usgs_usace_timeslices/"
            "reservoir_persistence_usgs" = ".TRUE."
            "reservoir_persistence_usace" = ".TRUE."
            "reservoir_usace_timeslice_path": "./NWM/usgs_usace_timeslices/"

Within wrfhydropy, in order for these files to be picked up by code, I needed to add the following two lines. This will add these files in the hydro_nlist:

if 'timeslice' in key and value != '':
                self.hydro_files.append(WrfHydroTs(file_path.glob('*')))
pep8speaks commented 4 years ago

Hello @ishita9! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-10-07 20:54:21 UTC
jmccreight commented 4 years ago

Does anyone understand why travis is not running on this PR? @rcabell @ishita9

rcabell commented 4 years ago

Does anyone understand why travis is not running on this PR? @rcabell @ishita9

Doesn't look like it's set up in the Integrations settings (only PEP8Speaks is listed currently). I'll look into it.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 603


Changes Missing Coverage Covered Lines Changed/Added Lines %
wrfhydropy/core/domain.py 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Totals Coverage Status
Change from base Build 602: -0.02%
Covered Lines: 3751
Relevant Lines: 4271

💛 - Coveralls