search

NCAR / wrf_hydro_py

Python API for the WRF-Hydro model
59 stars 43 forks source link

Feat gh actions #238

Closed jmccreight closed 1 year ago

jmccreight commented 1 year ago

@scrasmussen

jmccreight commented 1 year ago

this includes #230

scrasmussen commented 1 year ago

Thanks for this PR @jmccreight ! Sorry, I had somehow missed this and didn't see it until yesterday. I am spending some time right now trying to see what is causing the builds (other than the standard install) to fail, trying to see how difficult it will be to get them all working.

scrasmussen commented 1 year ago

@jmccreight Just a quick update, I've made a branch with updates to this pr. Dependencies updates and changes to fix failing CI tests. Currently there is only one test that is failing but it is a bit more difficult to fix than the others. I'll continue to work on it and then it looks like the Ubuntu and MacOS tests will all pass. Would you prefer me to merge those fixes into your feat_gh_actions branch so the CI tests are passing or merge your branch and then create new PR with my fixes?

jmccreight commented 1 year ago

Sorry, I was on vacation last week. It's totally up to you! I am no benevolent dictator for life on this! I think I would have done as you did. What is the test that's problematic? Maybe I have some idea if it's still plaguing you

James L. McCreight Research Hydrologist ~ Software Engineer USGS Enterprise Capacity UCAR CPAESS cell: 831-261-5149

On Thu, Jun 8, 2023 at 8:17 AM Soren Rasmussen @.***> wrote:

Merged #238 https://github.com/NCAR/wrf_hydro_py/pull/238 into main.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/wrf_hydro_py/pull/238#event-9473142621, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7DIYEJYWPA6EQ36VAG3Q3XKHNINANCNFSM6AAAAAAWR3JNPE . You are receiving this because you were mentioned.Message ID: @.***>

scrasmussen commented 1 year ago

@jmccreight No worries, hope you enjoyed your vacation! And are willing to accept a new role as "benevolent advisor" ; )

The failing Ubuntu test is test_ens_compose_restore. I was able to get it to pass by adding this if statement which checks differences in the unexpected_diffs from deepdiff. The only difference is the _compose_dir, which seems like an ok thing to just have a warning about, but I'm not sure.

If the _compose_dir difference is ok for just the test case but we want it to fail otherwise, I can edit the test_ens_compose_restore function so it does that.

The failing test message:

FAILED test_ensemble.py::test_ens_compose_restore - ValueError: ('Unexpected attribute
differences in unexpected members from DeepDiff output:', "root['_compose_dir']", ':', 
'/tmp/pytest-of-runner/pytest-0/test_ens_compose_restore0/ensemble_memory/member_000', ' 
!= ', '/tmp/pytest-of-runner/pytest-0/test_ens_compose_restore0/ensemble_memory
/member_001')