Closed mollymca closed 4 years ago
Is this something we want to merge? Based upon conversations on Slack, I'm thinking no.
yes. I just tested lesson 7 again. I spoke to soon to Laura. It needs the panda fix and the summary text added.
(Granted, I haven't loaded the panda fix to any of the other lessons, so I don't know if that makes a difference)
On Mon, Oct 14, 2019 at 2:18 PM Katelyn FitzGerald notifications@github.com wrote:
Is this something we want to merge? Based upon conversations on Slack, I'm thinking no.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/wrf_hydro_training/pull/272?email_source=notifications&email_token=AGQKPGLP6WTSZ3W2CWHMYTDQOTHZJA5CNFSM4JAS7422YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBGLI4I#issuecomment-541897841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGQKPGJI4GAUIALVQI6PG2LQOTHZJANCNFSM4JAS742Q .
-- Molly J. McAllister Associate Scientist III National Center for Atmospheric Research mollymca@ucar.edu office: (303) 497-8253 <%28303%29%20497-8404>
<%28831%29%20261-5149> My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.
In the last comment " (Granted, I haven't loaded the panda fix to any of the other lessons, so I don't know if that makes a difference)" Is in reference to testing. I only ran lessons, 1, 2, and 7 for this test.
On Mon, Oct 14, 2019 at 2:22 PM Molly McAllister mollymca@ucar.edu wrote:
yes. I just tested lesson 7 again. I spoke to soon to Laura. It needs the panda fix and the summary text added.
(Granted, I haven't loaded the panda fix to any of the other lessons, so I don't know if that makes a difference)
On Mon, Oct 14, 2019 at 2:18 PM Katelyn FitzGerald < notifications@github.com> wrote:
Is this something we want to merge? Based upon conversations on Slack, I'm thinking no.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/wrf_hydro_training/pull/272?email_source=notifications&email_token=AGQKPGLP6WTSZ3W2CWHMYTDQOTHZJA5CNFSM4JAS7422YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBGLI4I#issuecomment-541897841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGQKPGJI4GAUIALVQI6PG2LQOTHZJANCNFSM4JAS742Q .
-- Molly J. McAllister Associate Scientist III National Center for Atmospheric Research mollymca@ucar.edu office: (303) 497-8253 <%28303%29%20497-8404>
<%28831%29%20261-5149> My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.
-- Molly J. McAllister Associate Scientist III National Center for Atmospheric Research mollymca@ucar.edu office: (303) 497-8253 <%28303%29%20497-8404>
<%28831%29%20261-5149> My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.
Summary text definitely needs to be merged. You can use your best judgment regarding the panda fix.
On Mon, Oct 14, 2019 at 2:24 PM Molly McAllister mollymca@ucar.edu wrote:
In the last comment " (Granted, I haven't loaded the panda fix to any of the other lessons, so I don't know if that makes a difference)" Is in reference to testing. I only ran lessons, 1, 2, and 7 for this test.
On Mon, Oct 14, 2019 at 2:22 PM Molly McAllister mollymca@ucar.edu wrote:
yes. I just tested lesson 7 again. I spoke to soon to Laura. It needs the panda fix and the summary text added.
(Granted, I haven't loaded the panda fix to any of the other lessons, so I don't know if that makes a difference)
On Mon, Oct 14, 2019 at 2:18 PM Katelyn FitzGerald < notifications@github.com> wrote:
Is this something we want to merge? Based upon conversations on Slack, I'm thinking no.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NCAR/wrf_hydro_training/pull/272?email_source=notifications&email_token=AGQKPGLP6WTSZ3W2CWHMYTDQOTHZJA5CNFSM4JAS7422YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBGLI4I#issuecomment-541897841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGQKPGJI4GAUIALVQI6PG2LQOTHZJANCNFSM4JAS742Q .
-- Molly J. McAllister Associate Scientist III National Center for Atmospheric Research mollymca@ucar.edu office: (303) 497-8253 <%28303%29%20497-8404>
<%28831%29%20261-5149> My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.
-- Molly J. McAllister Associate Scientist III National Center for Atmospheric Research mollymca@ucar.edu office: (303) 497-8253 <%28303%29%20497-8404>
<%28831%29%20261-5149> My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.
-- Molly J. McAllister Associate Scientist III National Center for Atmospheric Research mollymca@ucar.edu office: (303) 497-8253 <%28303%29%20497-8404>
<%28831%29%20261-5149> My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.
Ok, I'll just merge this PR and then check on all of the Python imports when I run through the regridding again lesson here in a second.
I might not have the syntax write I was trying to add
from pandas.plotting import register_matplotlib_converters register_matplotlib_converters()