NCAR / wrfcloud

WRF Cloud Framework
Apache License 2.0
14 stars 6 forks source link

Hotfix/203 pcluster dep bug #205

Closed hahnd closed 1 year ago

hahnd commented 1 year ago

Same hotfix branch also merging the change into develop.

Pull Request Testing

Pull Request Checklist

hahnd commented 1 year ago

Yes, this was a bug affecting the current production release, so the git flow hotfix procedures were followed and the branch was made from the release tag.

I manually edited the version number to resolve the conflict.

In the future, should we hold off on changing the version number until we create the release branch?

georgemccabe commented 1 year ago

In the future, a single commit can be applied to another branch using the git cherry-pick command.

georgemccabe commented 1 year ago

I think we decided to set the version number X.Y.Z-dev to signify that it is development towards X.Y.Z, then change to X.Y.Z when we create the release. This helps discern whether the state of the code is an actual release or includes partial development towards the next release. This is how we name versions for METplus and it seems to be useful. I'm open to other approaches if another is preferred.

Yes, this was a bug affecting the current production release, so the git flow hotfix procedures were followed and the branch was made from the release tag.

I manually edited the version number to resolve the conflict.

In the future, should we hold off on changing the version number until we create the release branch?