Closed hahnd closed 1 year ago
Yes, this was a bug affecting the current production release, so the git flow hotfix procedures were followed and the branch was made from the release tag.
I manually edited the version number to resolve the conflict.
In the future, should we hold off on changing the version number until we create the release branch?
In the future, a single commit can be applied to another branch using the git cherry-pick command.
git cherry-pick <commit_hash>
e.g. git cherry-pick 90570361
I think we decided to set the version number X.Y.Z-dev to signify that it is development towards X.Y.Z, then change to X.Y.Z when we create the release. This helps discern whether the state of the code is an actual release or includes partial development towards the next release. This is how we name versions for METplus and it seems to be useful. I'm open to other approaches if another is preferred.
Yes, this was a bug affecting the current production release, so the git flow hotfix procedures were followed and the branch was made from the release tag.
I manually edited the version number to resolve the conflict.
In the future, should we hold off on changing the version number until we create the release branch?
Same hotfix branch also merging the change into develop.
Pull Request Testing
[ ] Describe testing already performed for these changes:
[ ] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
[ ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
[ ] Do these changes include sufficient testing updates? [Yes or No]
[ ] Will this PR result in changes to the test suite? [Yes or No] If yes, describe the new output and/or changes to the existing output:
[ ] Please complete this pull request review by [Fill in date].
Pull Request Checklist