NCAR / wrfcloud

WRF Cloud Framework
Apache License 2.0
15 stars 6 forks source link

Feature 214 change precip accum colorbar #215

Closed fossell closed 1 year ago

fossell commented 1 year ago

These changes close #214

Pull Request Testing

Pull Request Checklist

fossell commented 1 year ago

@georgemccabe or @hahnd - Could one of you please review and test? I don't know how to test these changes on the UI. I can take a look at the plot after it's updated to confirm it's what we're looking for, but just not sure how to deploy this. Thanks!

georgemccabe commented 1 year ago

@fossell , sure I can test it. I will have to start a cluster and run a job using your branch. Do you have a preference on which job to run? I can rerun an existing job.

fossell commented 1 year ago

@georgemccabe - Thanks! I was looking at W981D5734FB as an example, but really any job that has some precip is fine. Note that precip accum will be zero at initialization (fhr 0), so we don't expect anything at time zero, need a couple hours of output to confirm it's working properly.

georgemccabe commented 1 year ago

@fossell, OK I am currently running a new job W2714436F78 that uses the same configuration as W981D5734FB but will use your feature branch so we can compare new/old.

I noticed some jobs like W328106FD2E have all brown values for the 0 hr lead. Do you know why that would be?

georgemccabe commented 1 year ago

Job W2714436F78 used the changes. It looks like the 0 hr lead is all purple. I confirmed that all of the values are 0.

fossell commented 1 year ago

@georgemccabe - Thanks! This looks good. We should probably revisit color scales in the future. It would be nice to have all of the 0 data have no color and only start filling contours above a certain threshold, but that applies to more products and is beyond the scope of this issue. I'm happy with what we have here for now, if there is nothing else please approve and I'll merge. thanks!