Added sorting to make sure the downloaded GRIB files from NOMADS or S3 are first sorted alphabetically before linked to the GRIBFILE.AA* series for ungrib. This was previously only done for local data sources, this PR adds sorting for NOMADS and S3 data sources as well.
This PR will fix #65.
Expected Differences
[x] Do these changes modify the system output in any way? Yes
If yes, please describe:
The grib files linked to the GRIBFILE.AA* series will change and now be in correct order, as described in the issue.
Pull Request Testing
[x] Describe testing already performed for these changes:
This change was tested on Cheyenne by setting local_data to an empty string, e.g. local_data: '' in the run.yml file and then running run.py.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Check out the feature branch, change run.yml to havelocal_data: '' and then run run.py. Ensure that the GRIBFILE.AA* list in output/ungrib directory is linked to chronologically increasing forecast hours of the GRIB data.
[ ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
[ ] Do these changes include sufficient testing updates? [Yes or No]
[ ] Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
[ ] Please complete this pull request review by [Fill in date].
Monday, September 19
Pull Request Checklist
[x] Review the source issue metadata (labels, project, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Project
Select: Milestone as the version that will include these changes
Select: Development to link to the original development issue.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Added sorting to make sure the downloaded GRIB files from NOMADS or S3 are first sorted alphabetically before linked to the GRIBFILE.AA* series for ungrib. This was previously only done for local data sources, this PR adds sorting for NOMADS and S3 data sources as well. This PR will fix #65.
Expected Differences
[x] Do these changes modify the system output in any way? Yes If yes, please describe: The grib files linked to the GRIBFILE.AA* series will change and now be in correct order, as described in the issue.
Pull Request Testing
[x] Describe testing already performed for these changes: This change was tested on Cheyenne by setting local_data to an empty string, e.g.
local_data: ''in the run.yml file and then running run.py.[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Check out the feature branch, change run.yml to have
local_data: ''and then run run.py. Ensure that the GRIBFILE.AA* list in output/ungrib directory is linked to chronologically increasing forecast hours of the GRIB data.[ ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
[ ] Do these changes include sufficient testing updates? [Yes or No]
[ ] Will this PR result in changes to the test suite? [Yes or No] If yes, describe the new output and/or changes to the existing output:
[ ] Please complete this pull request review by [Fill in date]. Monday, September 19
Pull Request Checklist