Closed fossell closed 1 year ago
@hahnd @mkavulich - I committed your suggested changes and tested them, all works as expected. Please review again and approve if ready.
@mkavulich - I took all your suggestions, David approved, so I merged so I can work on the next piece. If you have any pressing issues with these mods please let me know.
Expected Differences
Pull Request Testing
[x] Describe testing already performed for these changes: The test case was performed on the AWS cluster and with just a couple forecast hours, e.g. editing test.yml enddate to only process two forecast hours. Grib files were transferred to local machine and inspected with wgrib2 utility to ensure valid data is being produced.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Edit the test.yml to process just a couple fhrs, e.g.
Run the system:
wrfcloud-run
Successful tests should result in the ungrib, metgrid, real, wrf, and upp components completing as normal. Check the /data/testrun/upp path and fhr_* subdirectories to ensure that grib files (WRFPRS.Grb.FXX) exist and are non-zero. Further inspection can be done by scp-ing one of the grib files to local machine and using wgrib2 to inspect the file, but not required at this point. In the future, might be nice to have wgrib2 installed in the AMI for development work.
[ ] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
[ ] Do these changes include sufficient testing updates? [Yes or No]
[ ] Will this PR result in changes to the test suite? [Yes or No] If yes, describe the new output and/or changes to the existing output:
[ ] Please complete this pull request review by [October 7, 2022].
Pull Request Checklist