Fix failure for chunks with all-zero values

davidhassell commented 8 months ago

Closes #194

Raised against branch pyfive for @bnlawrence

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist

[x] This pull request has a descriptive title and labels
[x] This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
[x] Unit tests have been added (if codecov test fails)
[x] Any changed dependencies have been added or removed correctly (if need be)
[x] All tests pass

valeriupredoi commented 8 months ago

@davidhassell did you upload that zero test file? https://github.com/valeriupredoi/PyActiveStorage/actions/runs/8419373236/job/23051840283?pr=196

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (pyfive@ef001ee). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## pyfive #196 +/- ## ========================================= Coverage ? 90.54% ========================================= Files ? 7 Lines ? 550 Branches ? 0 ========================================= Hits ? 498 Misses ? 52 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bnlawrence commented 8 months ago

Does this return a single missing number and a count 0 if the entire chunk is missing? Isn't that what it should do?

NCAS-CMS / PyActiveStorage