Closed sadielbartholomew closed 7 months ago
Just going to add one commit to fix a few style/formatting issues detected by the CI linting.
Thanks for your feedback @davidhassell. I'll update the PR shortly according to your excellent suggestions, though I will get the halo PR review in first, so do it after that.
All ready for your re-review, @davidhassell. Thanks.
Thanks David. In that case, merging!
Fix #758 and #756 (the former being the underlying issue and the latter a specific bug as a downstream effect) by overriding the
del_construct
inherited from cfdm to account for and update the store ofcyclic
axes. Previously we used the inherited method as-is so cyclic axes weren't updated and could get out of sync, notably contain axes which no longer existed due to deletion.Note:
test_Domain_del_construct
added here will currently fail halfway-through due to #762, as noted in the test. I am fixing that next.