Override `cfdm.Field.get_domain` to store axes cyclicity

NCAS-CMS / cf-python

A CF-compliant Earth Science data analysis library

http://ncas-cms.github.io/cf-python

MIT License

119 stars 19 forks source link

Override `cfdm.Field.get_domain` to store axes cyclicity #769

Closed sadielbartholomew closed 4 months ago

sadielbartholomew commented 4 months ago

Fix #762. The reason for the underlying issue was that the Field.domain attribute called get_domain which was inherited from cfdm, which doesn't have the concept of cyclic axes. So quite similar in terms of cause to #763 (maybe we should check there aren't further cases of cyclic axes not being accounted for, in case other bugs might exist?).

sadielbartholomew commented 4 months ago

Merging after offline acceptance from @davidhassell.