Correct finding coordrefs in `cf.aggregate`

NCAS-CMS / cf-python

A CF-compliant Earth Science data analysis library

http://ncas-cms.github.io/cf-python

MIT License

119 stars 19 forks source link

Correct finding coordrefs in `cf.aggregate` #783

Closed davidhassell closed 2 months ago

davidhassell commented 3 months ago

A bit tricky to test, as I can't see a case where the bug isn't benign: If two fields have different coordinate references, then they won't get aggregated anyway, regardless of whether or not any coordinate references are attached to dimension coordinates (which is the "bug")

sadielbartholomew commented 2 months ago

Hi David, were you wanting a review on this - not sure since it's open not as a draft and seems ready but I've not been assigned, so thought I'd check?

davidhassell commented 2 months ago

Got any ideas of what it could say (I haven't :))

sadielbartholomew commented 2 months ago

Got any ideas of what it could say (I haven't :))

You make a good point, I do not :laughing: Therefore, leaving this out from the changelog only makes sense - as you imply, the bug this fixes could only manifest for users if they are doing something really quite strange, so is unlikely.

So, all good - please merge.