search

NCAS-CMS / cfa-conventions

NetCDF Climate and Forecast Aggregation (CFA) Conventions
https://github.com/NCAS-CMS/cfa-conventions/blob/main/source/cfa.md
1 stars 1 forks source link

The fragment's data has the same data type as the aggregated data. #18

Closed davidhassell closed 3 years ago

davidhassell commented 3 years ago

Fixes #17

nmassey001 commented 3 years ago

Yes, I agree with this! 👍 Keeping things simple and well defined is good, I think.

davidhassell commented 3 years ago

Good - unless anyone shouts out in the next few days, I'll merge this.

sadielbartholomew commented 3 years ago

Good - unless anyone shouts out in the next few days, I'll merge this.

I also think these changes are good.

Note that it looks like there are some merge conflicts (here and also on the other open PR) which may be trivial but could potentially change some important details of each so it would be good to resolve those across the PRs to ensure there is no discord in the resultant text.

davidhassell commented 3 years ago

Thanks @nmassey001 and @sadielbartholomew. I'll resolve the conflicts and merge ...