NCAS-CMS / cfdm

A Python reference implementation of the CF data model
http://ncas-cms.github.io/cfdm
MIT License
28 stars 11 forks source link

Make `cfdm.read` always return unicode strings from netCDF files #252

Closed davidhassell closed 1 year ago

davidhassell commented 1 year ago

Fixes #251

codecov[bot] commented 1 year ago

Codecov Report

Merging #252 (0e8dfcf) into main (268693c) will decrease coverage by 0.01%. The diff coverage is 88.89%.

:exclamation: Current head 0e8dfcf differs from pull request most recent head 8cd0a4f. Consider uploading reports for the commit 8cd0a4f to get more accurate results

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   87.54%   87.52%   -0.01%     
==========================================
  Files         124      124              
  Lines       12804    12804              
==========================================
- Hits        11208    11206       -2     
- Misses       1596     1598       +2     
Flag Coverage Δ
unittests 87.52% <88.89%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cfdm/data/netcdfarray.py 68.30% <83.34%> (ø)
cfdm/examplefield.py 100.00% <100.00%> (ø)
cfdm/read_write/netcdf/netcdfread.py 83.88% <100.00%> (-0.04%) :arrow_down:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sadielbartholomew commented 1 year ago

@davidhassell are you looking for a review on this?