NCAS-CMS / cfdm

A Python reference implementation of the CF data model
http://ncas-cms.github.io/cfdm
MIT License
28 stars 11 forks source link

Refactor code for writing netCDF unlimited dimensions #267

Closed davidhassell closed 1 year ago

davidhassell commented 1 year ago

Refactor code for writing netCDF unlimited dimensions: Create a wrapper method in netcdfwrite.py to call cfdmimplementation.nc_is_unlimited_axis, rather than than the latter being called directly. (The wrapper already existed, but was not called.)

This is so that subclasses can modify the behaviour if needs be. E.g., cf-python needs to never write unlimited dimension to CFA-netCDF files.

codecov[bot] commented 1 year ago

Codecov Report

Merging #267 (14f77a9) into main (142accf) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   87.35%   87.36%   +0.02%     
==========================================
  Files         125      125              
  Lines       12887    12887              
==========================================
+ Hits        11256    11258       +2     
+ Misses       1631     1629       -2     
Flag Coverage Δ
unittests 87.36% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cfdm/read_write/netcdf/netcdfwrite.py 87.06% <100.00%> (+0.07%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more