Cfread updates - Githubissues

NCAS-CMS / cfstore

A CF compliant data store with interfaces to local and remote storage.

MIT License

2 stars 1 forks source link

Cfread updates #105

Closed georgeoobrienNCAS closed 1 year ago

georgeoobrienNCAS commented 1 year ago

Main aim is to improve how cf-read works

Remote aggregation now brings in .cfa files instead of .json (so parsing can be done locally)
Parsing the aggregation file into database-readable json is now done locally and skips the json step
The DB now stores proxied dictionaries as JSONFields (no change in functionality but works with Django)
Front-end has been updated to reflect this
The front-end css has now also been moved to a separate file as it should have always been. This isn't really related to the current pull request but it's snuck in there!

sadielbartholomew commented 1 year ago

@sadielbartholomew - would you be happy getting George set up with pre-commit on the repo? (no need for GitHub actions, I think ... yet.)

Sure thing. Are you in the office next Monday (or Tuesday) @georgeoobrienNCAS? If so I can come in too (probably would have anyway) to coordinate on this. I should add, I am sure you could set it all up yourself, but we've already done it for cf-python and other repos so it seems wise for me to walk you through what we did and probably save you time :slightly_smiling_face:

georgeoobrienNCAS commented 1 year ago

Sure, thing! Good suggestions there. I'll sneakily edit the description in - it's more useful as a top-level comment. Then if no other problems, I'll close this off and merge.