NCAS-CMS / cfunits

A Python interface to UNIDATA’s UDUNITS-2 library with CF extensions:
http://ncas-cms.github.io/cfunits
MIT License
11 stars 8 forks source link

ubuntu 16.04 reached EoL, therefore switch github action to ubuntu 18.04 in that case #38

Closed daniel-mohr closed 2 years ago

daniel-mohr commented 2 years ago

Since ubuntu 16.04 reached EoL (see actions/virtual-environments#3287), we have to switch the github action run-test-suite.yml to ubuntu 18.04.

daniel-mohr commented 2 years ago

Due to a change in the ubuntu github action (see actions/virtual-environments#4136) we need to do a apt-get update before installing packages sometimes. To not run in this problem once, I added this to run-test-suite_ubuntu_default_packages.yml.

codecov-commenter commented 2 years ago

Codecov Report

Merging #38 (574efd5) into master (0bd0e4d) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 574efd5 differs from pull request most recent head b28c2e0. Consider uploading reports for the commit b28c2e0 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files           2        2           
  Lines         677      677           
=======================================
  Hits          549      549           
  Misses        128      128           
Flag Coverage Δ
unittests 81.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0bd0e4d...b28c2e0. Read the comment docs.

sadielbartholomew commented 2 years ago

Thanks again @daniel-mohr. We'll get this PR, along with your other one open for cfunits, reviewed early next week.

daniel-mohr commented 2 years ago

@sadielbartholomew It's OK.

Development speed of your project is yours! ;-)

Thanks for accepting my work!