NCAS-CMS / pyfive

A pure Python HDF5 file reader
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

REFERENCE_LIST. Do we need to implement it? #11

Closed bnlawrence closed 2 months ago

bnlawrence commented 2 months ago

We have a problem when using pyfive as the backend for h5netcdf, which may boil down to the ability to deal with reference lists. It turns out we have one of those in the netcdf_classic file we used for the netcdf_classic test, but it doesn't cause any problems because it is never investigated in that test.

We now have a new test (test_reference_list.py) in the h5netcdf branch that currently traps the relevant warning and raises it as an error. The question at hand is, do we need to implement this at all.

It is noteworthy that is is only raised when you look for the dimensions of a coordinate axis ... is that a real use case?

bnlawrence commented 2 months ago

From https://docs.unidata.ucar.edu/netcdf-c/current/file_format_specifications.html via David Hassell's comment:

Attributes

Attributes in HDF5 and netCDF-4 correspond very closely. Each attribute in an HDF5 file is represented as an attribute in the netCDF-4 file, with the exception of the attributes below, which are hidden by the netCDF-4 API.

bnlawrence commented 2 months ago

Ok, it seems clear that we do not need to implement this, whatever the downstream problem is in h5netcdf.