search

NCATComp410 / comp410_fall_2020

Repository for COMP410 Fall 2020 Semester
GNU General Public License v3.0
0 stars 20 forks source link

Implement the stub function show traffic #57

Closed m-maque96 closed 4 years ago

m-maque96 commented 4 years ago

Work for sprint1 - master issue is #20

m-maque96 commented 4 years ago

Updated asa_parser.py with stub function for show traffic updated asaparser with show traffic

m-maque96 commented 4 years ago

Perform pytest and 9 passed in 0.35s pytest after adding show traffic stub func

m-maque96 commented 4 years ago

Performed Demo after updating with show traffic stub func. Screenshot of result below Inkedshow traffic demo_LI

m-maque96 commented 4 years ago

Included the show traffic stub function with the show interface stub function and included it with my work, within the same issue as the implement the stub function for show interface (#33). @dmeyer3691 @claesmk

claesmk commented 4 years ago

OK I linked this issue to the show interface pull request. In the future, best practice is to make the pull requests separate so they can be tracked separately. No need to re-do anything, just a comment for future improvement.

m-maque96 commented 4 years ago

I understand. I made the mistake of not closing that issue before making this one. Thank you very much.